CLN/TYPE: window aggregation cleanups and typing #30137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 7, 2019 12:39
WillAyd
requested changes
Dec 8, 2019
pandas/_libs/window/aggregations.pyx
Outdated
|
|
||
| is_monotonic_bounds = np.all(np.diff(start) > 0) and np.all(np.diff(end) > 0) |
There was a problem hiding this comment.
Can you make this a cdef function instead of copy?
| @@ -412,7 +412,7 @@ def _get_roll_func(self, func_name: str) -> Callable: | |||
| ) | |||
| return window_func | |||
|
|
|||
| def _get_cython_func_type(self, func): | |||
| def _get_cython_func_type(self, func: str) -> Callable: | |||
There was a problem hiding this comment.
If possible to add subtypes to Callable typically very helpful
There was a problem hiding this comment.
Unfortunately the arguments to the cython functions for rolling are still not entirely uniform so the argument list can't be typed consistently.
jbrockmendel
reviewed
Dec 8, 2019
pandas/_libs/window/aggregations.pyx
Outdated
|
|
||
| is_monotonic_bounds = np.all(np.diff(start) > 0) and np.all(np.diff(end) > 0) |
There was a problem hiding this comment.
is this call expensive? we might have something in _libs.algos that short-circuits this check
There was a problem hiding this comment.
Good call. Was able to use is_monotonic in _libs.algos
jreback
requested changes
Dec 8, 2019
pandas/_libs/window/aggregations.pyx
Outdated
|
|
||
| is_monotonic_bounds = np.all(np.diff(start) > 0) and np.all(np.diff(end) > 0) |
jreback
reviewed
Dec 8, 2019
pandas/_libs/window/aggregations.pyx
Outdated
|
|
||
| is_monotonic_bounds = is_monotonic(start, False)[0] and is_monotonic(end, False)[0] |
There was a problem hiding this comment.
worth making this an inline helper function (not a big deal though)
|
All green. |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
* Move is_monotonic_bounds to the aggregation functions * Remove single usage of _check_min in aggregations.pyx * remove _check_min * Add some typing * fix condition * Use is_monotonic from _lib.algos * Add inline helper function
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
* Move is_monotonic_bounds to the aggregation functions * Remove single usage of _check_min in aggregations.pyx * remove _check_min * Add some typing * fix condition * Use is_monotonic from _lib.algos * Add inline helper function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff